Helping Review PRs

Give back by reviewing others' work.

Code Review Responsibilities

Understand the change
Check if it solves the problem
Verify tests are adequate
Catch potential bugs
Ensure code quality

How to Review Well

1. Read the PR description
   ↓ Understand what they're trying to do

2. Check the code changes
   ↓ Does it do what it claims?

3. Look for issues
   ↓ Are there bugs? Edge cases?

4. Verify tests
   ↓ Are they adequate? Do they pass?

5. Provide feedback
   ↓ Be kind and constructive

Review Comments

❌ Bad:
"This is wrong"

✅ Good:
"I see you're using sync queries here. 
 For large datasets, this could block 
 the event loop. Did you consider using 
 async/await? Here's an example: [link]"

What Reviewers Look For

Code style consistency
Security implications
Performance considerations
Test coverage
Documentation updates
Breaking changes

Good reviews make better code. Learn to review well and you're valuable.

Taking Ownership Design Documents